Remove init variable in Reclaimable and Preemptable parts of session_plugins

[PigNatovsky]

Hello,

it's a really small - so called - refactor. I've just changed values of init variable which shows if this is the first iteration of Reclaimable/Preemptable. In my opinion this if:

if init {
    victims = candidates
    init = false
}

is more readable than:

if !init {
    victims = candidates
    init = true
}

It's like a double negation.

[PigNatovsky]

/assign @lowang-bh

[lowang-bh]

How about use inited instead of init?

[PigNatovsky]

@lowang-bh @googs1025
I've pushed new commit with changes suggested by @googs1025 - as a reader I can say that it's pretty readable and I can understand a code flow.

[PigNatovsky]

Hello Guys,

Could You comment? If changes are too small and unimportant, just let me know, I will close this.

And thank You for the previous reaponses!

[googs1025]

/assign @Monokaix
hi @Monokaix Maybe you can take a look and suggest an edit!

[Monokaix]

/assign @Monokaix hi @Monokaix Maybe you can take a look and suggest an edit!

I think it's ok: )

[Monokaix]

/lgtm

[PigNatovsky]

Thank You @Monokaix . And sorry for stupid question, but what should I do next?

[googs1025]

Thank You @Monokaix . And sorry for stupid question, but what should I do next?

Just wait for other approver to be reviewed and merged. 👍

[PigNatovsky]

@hudson741 @k82cn @googs1025
Is there a chance to get review/something with this small change, or should I abandon it and close?

[Monokaix]

Please rebase and squash to one commit: )

[PigNatovsky]

/assign @Monokaix

[Monokaix]

/assign @Monokaix

You can just keep your own commit and remove Merge Branch xxx to kepp a clean commit: )

[PigNatovsky]

Sorry, I was using a button in the PR UI to merge master branch, it's not the best idea. But now branch is rebased from master, my commit is on the tip.

[Monokaix]

/lgtm
/approve

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/scheduler/OWNERS [Monokaix]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Monokaix]

/ok-to-test