Volcano adapts to the k8s v1.30 #3556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/XXL
guoqinwill
force-pushed
the
adapt-k8s1.30
branch
2 times, most recently
from
96ecc38 to
921ab32
Compare
volcano-sh-bot
added
size/XL
guoqinwill
force-pushed
the
adapt-k8s1.30
branch
7 times, most recently
from
2361e24 to
de6ff3a
Compare
|
It is better to squash 3534's commits. |
lowang-bh
reviewed
Jul 6, 2024
| @@ -19,6 +19,7 @@ package volumebinding | |||
| import ( | |||
| "context" | |||
| "testing" | |||
| "volcano.sh/volcano/cmd/scheduler/app/options" | |||
lowang-bh
reviewed
Jul 6, 2024
| @@ -2457,12 +2457,12 @@ func TestGetEligibleNodes(t *testing.T) { | |||
| eligibleNodes := testEnv.binder.GetEligibleNodes(logger, scenario.pvcs) | |||
|
|
|||
| // Validate | |||
| if equality.Semantic.DeepEqual(scenario.eligibleNodes, eligibleNodes) { | |||
| if reflect.DeepEqual(scenario.eligibleNodes, eligibleNodes) { | |||
There was a problem hiding this comment.
Is this changed back to reflect.DeepEqual?
There was a problem hiding this comment.
There was a deviation in conflict resolution and it has been fixed.
Signed-off-by: wangyysde <net_use@bzhy.com>
Signed-off-by: guoqinwill <guoqinwill@163.com>
Signed-off-by: guoqinwill <guoqinwill@163.com>
done |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3523
cherry pick and update：https://github.com/volcano-sh/volcano/pull/3534/commits