controllers: fix miscalculation of RunningDuration when killing job #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome @matbme! |
volcano-sh-bot
added
the
do-not-merge/invalid-commit-message
volcano-sh-bot
added
the
size/S
matbme
force-pushed
the
gcRunningDuration
branch
from
7aecf9a
to
2fb4d7a
Compare
volcano-sh-bot
removed
the
do-not-merge/invalid-commit-message
|
/assign @Monokaix |
matbme
force-pushed
the
gcRunningDuration
branch
from
2fb4d7a
to
04870f9
Compare
volcano-sh-bot
added
ok-to-test
Monokaix
reviewed
Sep 12, 2024
|
/lgtm |
|
Hi, please rebase master. |
|
/assign @hwdef |
|
Could you please paste a test result or add an ut? |
|
Here's a manual test I did with and without this PR applied: # ---------- Without PR ----------
$ k describe jobs.batch.volcano.sh test-workload-1 | grep -B 11 'Running Duration'
Status:
Conditions:
Last Transition Time: 2024-09-17T19:25:22Z
Status: Pending
Last Transition Time: 2024-09-17T19:25:54Z
Status: Running
Last Transition Time: 2024-09-17T19:26:12Z
Status: Completing
Last Transition Time: 2024-09-17T19:26:12Z
Status: Completed
Min Available: 1
Running Duration: 6m8.810943003s
$ k -n volcano-system rollout restart deployment volcano-controllers
deployment.apps/volcano-controllers restarted
$ k describe jobs.batch.volcano.sh test-workload-1 | grep -B 11 'Running Duration'
Status:
Conditions:
Last Transition Time: 2024-09-17T19:25:22Z
Status: Pending
Last Transition Time: 2024-09-17T19:25:54Z
Status: Running
Last Transition Time: 2024-09-17T19:26:12Z
Status: Completing
Last Transition Time: 2024-09-17T19:26:12Z
Status: Completed
Min Available: 1
Running Duration: 8m36.103534833s
# ---------- With PR ----------
$ k describe jobs.batch.volcano.sh test-workload-1 | grep -B 11 'Running Duration'
Status:
Conditions:
Last Transition Time: 2024-09-17T19:25:22Z
Status: Pending
Last Transition Time: 2024-09-17T19:25:54Z
Status: Running
Last Transition Time: 2024-09-17T19:26:12Z
Status: Completing
Last Transition Time: 2024-09-17T19:26:12Z
Status: Completed
Min Available: 1
Running Duration: 51s
$ k -n volcano-system rollout restart deployment volcano-controllers
deployment.apps/volcano-controllers restarted
$ k describe jobs.batch.volcano.sh test-workload-1 | grep -B 11 'Running Duration'
Status:
Conditions:
Last Transition Time: 2024-09-17T19:25:22Z
Status: Pending
Last Transition Time: 2024-09-17T19:25:54Z
Status: Running
Last Transition Time: 2024-09-17T19:26:12Z
Status: Completing
Last Transition Time: 2024-09-17T19:26:12Z
Status: Completed
Min Available: 1
Running Duration: 51sNote that Regarding unit tests, I originally intended to add a test for this scenario, but had trouble replicating this behavior inside a ut. Please let me know if you have any indicators on how I could achieve this (maybe a e2e would be more fitting). |
|
Please squash to one commit: ) |
matbme
force-pushed
the
gcRunningDuration
branch
from
6878089
to
72d3140
Compare
volcano-sh-bot
added
size/L
Uses the last transition time instead of current time to determine total running duration. Signed-off-by: Mateus Melchiades <mateus.melchiades@sap.com>
matbme
force-pushed
the
gcRunningDuration
branch
from
2646e56
to
c700b70
Compare
|
Done! |
|
@william-wang @Thor-wl @shinytang6 |
|
Hi! Any updates on the CI? |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When restarting a controller pod, it calls
killJobon completed jobs which will erroneously change theRunningDurationvalue for said job, even though it had already been completed. This PR fixes the issue by using the last transition time instead of current time to determine total running duration insidekillJob.Closes #3715.