-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hierarchical queues for capacity plugin #3743
base: master
Are you sure you want to change the base?
Conversation
ref: #3590 |
/assign @Monokaix @lowang-bh @shinytang6 |
pkg/webhooks/admission/queues/mutate/mutate_hierarchical_queue.go
Outdated
Show resolved
Hide resolved
pkg/webhooks/admission/queues/mutate/mutate_hierarchical_queue.go
Outdated
Show resolved
Hide resolved
pkg/webhooks/admission/queues/validate/validate_hierarchical_queue.go
Outdated
Show resolved
Hide resolved
Is somewhere validate that job can only be submitted to leaf node? |
Please add some E2E test for this function. Because this function is very important. |
pkg/webhooks/admission/queues/mutate/mutate_hierarchical_queue.go
Outdated
Show resolved
Hide resolved
I will add it later |
I have already added this logic in the validate webhook of the job to ensure that jobs can only be submitted to leaf queues. |
/cc |
Please consider this scenario:
I believe this is how most existing users use hierarchical queues. result:
|
hierarchyEnabled := cp.HierarchyEnabled(ssn) | ||
readyToschedule := true | ||
if hierarchyEnabled { | ||
readyToschedule = cp.buildHierarchicalQueueAttrs(ssn) | ||
} else { | ||
cp.buildQueueAttrs(ssn) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will placing these logic in onsessionopen have any impact on performance?
I got some errors when create a vcjob
|
/ok-to-test |
In the scenario of scheduling directly with Maybe we need a |
Thank you for your suggestion. I will add the missing logic. |
Signed-off-by: Rui-Gan <ganrui.cs@gmail.com>
Signed-off-by: Rui-Gan <ganrui.cs@gmail.com>
Signed-off-by: Rui-Gan <ganrui.cs@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Rui-Gan <ganrui.cs@gmail.com>
Signed-off-by: Rui-Gan <ganrui.cs@gmail.com>
005ab18
to
f69ac4c
Compare
Signed-off-by: Rui-Gan <ganrui.cs@gmail.com>
No description provided.