Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support KUBECON env. #485

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Support KUBECON env. #485

merged 1 commit into from
Oct 21, 2019

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Oct 19, 2019

Signed-off-by: Klaus Ma mada3@huawei.com

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2019
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 19, 2019

if kubeConfFile == "" && fileExist(defaultKubeConfigFile) {
kubeConfFile = defaultKubeConfigFile
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kubeConfFile := os.Getenv("KUBECONFIG")
if kubeConfFile == "" {
kubeConfFile = filepath.Join(homeDir(), ".kube", "config")
}

@TravisBuddy
Copy link

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 82602760-f217-11e9-8575-bb3eea981d29

@TravisBuddy
Copy link

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 853d56b0-f217-11e9-8575-bb3eea981d29

@TravisBuddy
Copy link

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: c455a550-f230-11e9-8575-bb3eea981d29

Signed-off-by: Klaus Ma <mada3@huawei.com>
@TravisBuddy
Copy link

Hey @k82cn,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 8b093a10-f2de-11e9-a94e-c51b88d78b8d

@hzxuzhonghu
Copy link
Collaborator

Let this in, and i will fix the e2e

@hzxuzhonghu hzxuzhonghu merged commit 44cccd4 into volcano-sh:master Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants