Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format function name #494

Merged
merged 2 commits into from
Oct 30, 2019
Merged

format function name #494

merged 2 commits into from
Oct 30, 2019

Conversation

hzxuzhonghu
Copy link
Collaborator

This is to test volcano-bot

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 29, 2019
@hzxuzhonghu hzxuzhonghu added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Oct 29, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: hzxuzhonghu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 11e69360-fa42-11e9-97f1-ff8640b58534

@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: a285bd10-fa42-11e9-97f1-ff8640b58534

@sivanzcw sivanzcw mentioned this pull request Oct 29, 2019
Merged
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
@volcano-sh-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@hzxuzhonghu hzxuzhonghu added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
@TravisBuddy
Copy link

Hey @hzxuzhonghu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 7cff2db0-faba-11e9-94bd-fbbf6873bcfd

@volcano-sh-bot volcano-sh-bot merged commit 87fe68f into volcano-sh:master Oct 30, 2019
@hzxuzhonghu hzxuzhonghu deleted the tmp branch October 30, 2019 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hex108 hex108 Awaiting requested review from hex108

@quinton-hoole quinton-hoole Awaiting requested review from quinton-hoole

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hzxuzhonghu @volcano-sh-bot @TravisBuddy