Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request to be a reviewer #500

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Request to be a reviewer #500

merged 1 commit into from
Oct 31, 2019

Conversation

yuanchen8911
Copy link
Contributor

Would like to make more contributions.

@yuanchen8911
Request to be a reviewer
f1d8d07 
Would like to make more contributions.
@volcano-sh-bot volcano-sh-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Oct 31, 2019
@volcano-sh-bot
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are not members of the volcano-sh org.

Once all users have been added as members of the org, you can trigger verification by writing /verify-owners in a comment.

  • yuanchen8911
    • OWNERS

@yuanchen8911
Copy link
Contributor Author

/assign @k82cn

@TravisBuddy
Copy link

Hey @yuanchen8911,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 2834f0c0-fb7e-11e9-94d3-31634e859ee1

@hzxuzhonghu
Copy link
Collaborator

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@k82cn
Copy link
Member

k82cn commented Oct 31, 2019

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, yuanchen8911

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@k82cn k82cn merged commit 5ab6963 into volcano-sh:master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hex108 hex108 Awaiting requested review from hex108

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@hzxuzhonghu hzxuzhonghu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. lgtm Indicates that a PR is ready to be merged. retest-not-required-docs-only size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yuanchen8911 @volcano-sh-bot @TravisBuddy @hzxuzhonghu @k82cn