Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix podgroup phase #513

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Conversation

wangyuqing4
Copy link
Contributor

when i use job.yaml

apiVersion: batch.volcano.sh/v1alpha1                                                                                                                                       
kind: Job 
metadata:
  generateName: job-xxx
spec:
  minAvailable: 4
  schedulerName: volcano
  plugins:
    ssh: []
    env: []
    svc: []
  policies:
  - event: PodFailed
    action: RestartJob
  tasks:
  - replicas: 1
    name: "mpimaster"
    template:
      spec:
        imagePullSecrets:
          - name: default-secret
        containers:
        - command:
            - /bin/sh
            - -c
            - | 
              mkdir -p /var/run/sshd; /usr/sbin/sshd; sleep 10;
          image: openmpi-hello:1.0
          imagePullPolicy: IfNotPresent
          name: mpimaster
          ports:
          - containerPort: 2222
            name: mpijob-port
          workingDir: /home
          resources:
            limits:
              cpu: 3750m
        restartPolicy: OnFailure
  - replicas: 3
    name: mpiworker
    template:
      spec:
        imagePullSecrets:
          - name: default-secret
        containers:
        - command:
            - /bin/sh
            - -c
            - |
              mkdir -p /var/run/sshd; /usr/sbin/sshd; sleep 5;
          image: openmpi-hello:1.0
          imagePullPolicy: IfNotPresent
          name: mpiworker
          ports:
          - containerPort: 2222
            name: mpijob-port
          workingDir: /home
          resources:
            limits:
              cpu: 3750m
        restartPolicy: OnFailure

i use kubectl create -f job.yaml, but phase of podgroup make me confused.

    | PG phase |        Pod             |
    | -------- | ---------------------- |
    | Pending  | none                   |
    | Inqueue  | 4 Pending              |
    | Running  | 4 Running              |
    | Pending  | 1 Running  3 Compeletd |
   

so i fix, when calc allocated num, include succeeded pod.

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 7, 2019
@hzxuzhonghu
Copy link
Collaborator

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2019
@hzxuzhonghu
Copy link
Collaborator

maybe fix #457, will have a test

@TravisBuddy
Copy link

Hey @wangyuqing4,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 9e459510-0116-11ea-82f1-cf3ba55cf6d0

@k82cn
Copy link
Member

k82cn commented Nov 7, 2019

/lgtm
/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, wangyuqing4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2019
@volcano-sh-bot volcano-sh-bot merged commit 124d6aa into volcano-sh:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants