Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added localup script. #601

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Dec 11, 2019

Signed-off-by: Klaus Ma klaus1982.cn@gmail.com

@volcano-sh-bot volcano-sh-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2019
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2019
@TravisBuddy
Copy link

Hey @k82cn,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: c9722af0-1c2d-11ea-ba59-e12deadb3a4c

@TravisBuddy
Copy link

Hey @k82cn,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 31049a40-1c2e-11ea-ba59-e12deadb3a4c

@hzxuzhonghu
Copy link
Collaborator

Is it worth building k8s binaries from code and start up the components one by one in cmd line? Suggest using the existing tools kubeadm or minikube.

Signed-off-by: Klaus Ma <klaus1982.cn@gmail.com>
@k82cn k82cn changed the title WIP: Added localup script. Added localup script. Dec 13, 2019
@volcano-sh-bot volcano-sh-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 13, 2019
@k82cn
Copy link
Member Author

k82cn commented Dec 13, 2019

submit first version, we'll enhance it with more detail.

@k82cn k82cn added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2019
@TravisBuddy
Copy link

Hey @k82cn,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 0aa3d340-1d71-11ea-a2fb-51cb67500490

@volcano-sh-bot volcano-sh-bot merged commit 5348a8d into volcano-sh:master Dec 13, 2019
@k82cn k82cn deleted the local_cluster branch December 25, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants