Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add defaultQPS and defaultBurst for webhook-manager #663

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

yuzhaojing
Copy link

Use the same QPS and Burst as the scheduler.

@volcano-sh-bot
Copy link
Contributor

Welcome @yuzhaojing!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 8, 2020
@k82cn
Copy link
Member

k82cn commented Jan 8, 2020

Good catch!

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 8, 2020
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, yuzhaojing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 8, 2020
@TravisBuddy
Copy link

Hey @yuzhaojing,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 3ad20560-3201-11ea-8b14-75ea274a9bd6

@volcano-sh-bot volcano-sh-bot merged commit 58c2ad9 into volcano-sh:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants