Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint: fix deadcode issue #825

Merged
merged 1 commit into from
May 22, 2020
Merged

Lint: fix deadcode issue #825

merged 1 commit into from
May 22, 2020

Conversation

daixiang0
Copy link
Contributor

Signed-off-by: Xiang Dai long0dai@foxmail.com

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 21, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @daixiang0,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 778e6c90-9b6b-11ea-acf2-2540bfc6cd37

@TravisBuddy
Copy link

Travis tests have failed

Hey @daixiang0,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 778803f0-9b6b-11ea-acf2-2540bfc6cd37

@TravisBuddy
Copy link

Travis tests have failed

Hey @daixiang0,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

TravisBuddy Request Identifier: 4fdcbda0-9bd4-11ea-9438-0b74518d636c

@daixiang0
Lint: fix deadcode issue
ada2020 
Signed-off-by: Xiang Dai <long0dai@foxmail.com>
@k82cn
Copy link
Member

k82cn commented May 22, 2020

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2020
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daixiang0, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2020
@volcano-sh-bot volcano-sh-bot merged commit ae7b322 into volcano-sh:master May 22, 2020
@daixiang0 daixiang0 deleted the deadcode branch May 23, 2020 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu hzxuzhonghu left review comments

@k82cn k82cn Awaiting requested review from k82cn

@kevin-wangzefeng kevin-wangzefeng Awaiting requested review from kevin-wangzefeng

Assignees

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daixiang0 @TravisBuddy @k82cn @volcano-sh-bot @hzxuzhonghu