Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #342 Non-Clickable Buttons #349

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

Shruti78
Copy link
Contributor

@Shruti78 Shruti78 commented Feb 8, 2025

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

@volcano-sh-bot volcano-sh-bot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 8, 2025
@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 8, 2025
@Shruti78 Shruti78 changed the title Fixed Non-Clickable "Star" and "Learn More About Volcano" Buttons Fixed #342 Non-Clickable "Star" and "Learn More About Volcano" Buttons Feb 8, 2025
Update home page style and update some docs

Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com>
@Shruti78
Copy link
Contributor Author

Shruti78 commented Feb 8, 2025

/assign @kevin-wangzefeng

@Shruti78 Shruti78 changed the title Fixed #342 Non-Clickable "Star" and "Learn More About Volcano" Buttons Fixed #342 Non-Clickable Buttons Feb 8, 2025
@Shruti78 Shruti78 force-pushed the fix/button-clickable branch from 22b4352 to 2a61c96 Compare February 8, 2025 16:49
@volcano-sh-bot volcano-sh-bot added retest-not-required-docs-only approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 8, 2025
Signed-off-by: Shruti78 <shrutimurthy2103@gmail.com>
@volcano-sh-bot volcano-sh-bot removed retest-not-required-docs-only approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 8, 2025
@Shruti78
Copy link
Contributor Author

/assign @kevin-wangzefeng

@Monokaix
Copy link
Member

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 11, 2025
@JesseStutler
Copy link
Member

Great!

@kevin-wangzefeng
Copy link
Member

/approve
Thanks

@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevin-wangzefeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 11, 2025
@volcano-sh-bot volcano-sh-bot merged commit 104bd22 into volcano-sh:master Feb 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants