-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check availability of theseus/mmligner executables #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don't have Windows versions for
theseus
andmmligner
as of now, thus currently no working Windowsopencadd
version.Our workaround suggested by @jaimergp:
Add safety checks for these packages (incl. informative text for our users). With such a workaround we will be able to offer this package for Windows, too (without functionality for the bits that need
theseus
andmmligner
though).If these packages will be available in the future, the respective bits in
opencadd
will work out-of-the-box, too.More background details:
opencadd
are not on windowsopencadd
Todos
.safety_checks()
method toBaseAligner
but implement code in respective classes, see below_safety_checks()
implementation toTheseusAligner
andMMLignerAligner
:_safety_checks()
to [MDAnalysisAligner
]; only added for consistency across engines; simply passes (no executable check necessary since conda package available for all OS)BaseAligner.calculate
methodQuestions
None.
Status