Fix version check for Elixir #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this patch, we couldn't use this package because it was
crashing when using Elixir pre-releases (here, 1.18.0-dev):
== Compilation error in file lib/x509/logger.ex ==
** (ArgumentError) errors were found at the given arguments:
* 1st argument: not a textual representation of an integer
:erlang.binary_to_integer("0-dev")
(elixir 1.18.0-dev) lib/enum.ex:1703: Enum."-map/2-lists^map/1-1-"/2
(elixir 1.18.0-dev) lib/enum.ex:1703: Enum."-map/2-lists^map/1-1-"/2
lib/x509/logger.ex:7: (module)
This is now fixed. `X509.Util.app_version/1` is still used in a couple
other places but just for applications that ship with OTP and they
should not have this problem.
wojtekmach
force-pushed
the
wm-fix-version-check
branch
from
8336a5c to
17cb3bb
Compare
voltone
approved these changes
Jun 27, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch, we couldn't use this package because it was crashing when using Elixir pre-releases (here, 1.18.0-dev):
This is now fixed.
X509.Util.app_version/1is still used in a couple other places but just for applications that ship with OTP and they should not have this problem.