Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: More renames for wapi #46

Merged
merged 5 commits into from
Nov 22, 2023
Merged

docs: More renames for wapi #46

merged 5 commits into from
Nov 22, 2023

Conversation

deep-volue
Copy link
Contributor

No description provided.

@stigalvestad stigalvestad changed the title docs: More renames for wapi to vits docs: More renames for wapi Nov 21, 2023
stigalvestad
stigalvestad requested changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@stigalvestad stigalvestad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! See my comment on the naming.
Can you also correct the double https://https// here:

volue-insight-timeseries/docs/quickstart.rst

Line 65 in 610df35

.. _authentication credentials: https://https://auth.volueinsight.com/account/oauth-clients
and include that in this PR?

docs/events.rst Outdated Show resolved Hide resolved
@deep-volue @stigalvestad
Update docs/events.rst
5f7503e 
Co-authored-by: Stig Alvestad  <sal@wattsight.com>
@deep-volue
Copy link
Contributor Author

Good! See my comment on the naming. Can you also correct the double https://https// here:

volue-insight-timeseries/docs/quickstart.rst

Line 65 in 610df35

.. _authentication credentials: https://https://auth.volueinsight.com/account/oauth-clients

and include that in this PR?

Yes, I removed that double https

stigalvestad
stigalvestad approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@stigalvestad stigalvestad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this is good!

@deep-volue deep-volue merged commit 604b99e into development Nov 22, 2023
7 checks passed
@deep-volue deep-volue deleted the more-doc-updates branch November 22, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigalvestad stigalvestad stigalvestad approved these changes

@hieuhc hieuhc Awaiting requested review from hieuhc

Assignees
No one assigned
Labels
dependencies feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deep-volue @stigalvestad