Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete from Playlist with track coming from youtube2 or spotify #2154

Open
barais opened this issue Sep 24, 2021 · 1 comment
Open

Delete from Playlist with track coming from youtube2 or spotify #2154

barais opened this issue Sep 24, 2021 · 1 comment

Comments

@barais
Copy link

barais commented Sep 24, 2021

It seems that there is an issue on removing an element from playlist see [1,2].

The service name is not the correct one. A solution could be to change a bit this line.

if (data[i].service == service && data[i].uri == uri) {

to

        if (/*data[i].service == service && */ data[i].uri == uri) {

in function commonRemoveFromPlaylist. For me, if the item has the right uri in a playlist, you could probably remove the test on the service namebut I'm probably missing something. The real bug is probably in the user interface. (Anyway, for items coming from youtube2 or spotify, the service names do not match 'mpd vs spot'

[1] https://community.volumio.org/t/volumio-playlist-remove-from-playlist-not-working/38982/3
[2] https://community.volumio.org/t/delete-from-playlist-does-not-work/9899/3

patrickkfkan added a commit to patrickkfkan/Volumio2 that referenced this issue Oct 5, 2021
@patrickkfkan
Copy link
Contributor

patrickkfkan commented Oct 5, 2021

The real culprit is in

var returnedData = self.commandRouter.playListManager.removeFromPlaylist(data.name, 'mpd', data.uri);

I pointed this out back in April:
https://community.volumio.org/t/removing-playlists/46895/4

Still hasn't been fixed, so I've created a PR for this.

volumio pushed a commit that referenced this issue Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants