Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VP-943 Use exists instead of isEmpty #544

Merged
merged 2 commits into from
Dec 18, 2019

Conversation

tyrannosaurusjames
Copy link
Contributor

I do solemnly swear that I have:

  • Run npm test and all the tests pass.
  • Run npm run lint and there are no warnings.
  • Not decreased the overall test coverage?
  • Included the Jira ID and description in the PR title

Proposed Changes? 🤔

  1. Fix a deprecation warning that was being generated while running unit tests

Additional info

Enzyme has deprecated use of isEmpty and recommend using exists instead.

There is a brief discussion of the deprecation here: enzymejs/enzyme#705

Enzyme has deprecated use of isEmpty and recommend using exists instead.
@codecov
Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #544 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #544   +/-   ##
======================================
  Coverage    80.8%   80.8%           
======================================
  Files         230     230           
  Lines        3439    3439           
======================================
  Hits         2779    2779           
  Misses        660     660

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 05e7bcb...b41750e. Read the comment docs.

@avowkind avowkind merged commit 20a7bdc into master Dec 18, 2019
@avowkind avowkind deleted the fix/VP-943/enzyme-deprecated-warning branch December 18, 2019 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants