Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GraphQL support for GitLab API queries #111

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add GraphQL support for GitLab API queries #111

wants to merge 2 commits into from

Conversation

Simon-1-1
Copy link
Contributor

@Simon-1-1 Simon-1-1 commented Dec 29, 2023 •
edited
Loading

Closes #110

@Simon-1-1
Use parameter flag instead of inline flag in regex
a38874a 
Using (?i) inside a regex is deprecated. It is still possible to use it
at the start of the regex. I consider it clearer to have the flags as
parameters instead of inside the regex string. So I set the
re.IGNORECASE parameter flag instead.

Also added a test for the function where the regex is used.
@Simon-1-1
Refactor getting review data with API v4
1fca79b 
Refactored `app.py` to have the getting of data from GitLab using version
4 of the API in its own function. This will help to support GraphQL in
parallel later.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plaos plaos Awaiting requested review from plaos

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use GraphQL instead of REST
1 participant
@Simon-1-1