Skip to content

Commit

Permalink
(Re)set minimal Java version to (again) be 8 instead of 11 (fixes #142)
Browse files Browse the repository at this point in the history
  • Loading branch information
vorburger committed Jun 16, 2024
1 parent 040283c commit 9a9c2bc
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
# Nota Bene: Even though the project (currently) targets Java 8 API level,
# we cannot build it under Java 8 anymore, because Error Prone (which we use)
# must be run on JDK 11 or newer (but we can and are still using
# source/target/release 8 instead 11 in the pom.xml).
java: [ '11', '17', '21' ]
name: Java ${{ matrix.Java }} CI
steps:
Expand Down
6 changes: 4 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,13 @@
<version>3.13.0</version>
<configuration>
<!-- Keep the Java version aligned with .github/workflows/maven.yml -->
<release>11</release>
<source>8</source>
<target>8</target>
<release>8</release>
<showWarnings>true</showWarnings>
<compilerArgs>
<arg>-Werror</arg>
<arg>-Xlint:all</arg>
<arg>-Xlint:all,-options</arg>
<arg>-XDcompilePolicy=simple</arg>
<arg>-Xplugin:ErrorProne -XepAllDisabledChecksAsWarnings
-Xep:BooleanParameter:OFF -Xep:AndroidJdkLibsChecker:OFF
Expand Down

0 comments on commit 9a9c2bc

Please sign in to comment.