-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 8 instead of 11 #117
Comments
An alternative approach here, particularly interesting if some Maven plugin or something doesn't work well under Java 8 anymore for CI (on MariaDB4j there was some PITA about this; I can't remember the details), may be to keep Java 11 on CI but contribute something like the https://www.mojohaus.org/animal-sniffer/animal-sniffer-maven-plugin/ (or perhaps https://openjdk.org/jeps/247; I did not even know that existed, but stumbled upon it from the link on https://github.com/mojohaus/animal-sniffer). |
There is also a bit of an inconsistency with |
Actually, if it isn't already, this will become the case with the merge of #119, note https://errorprone.info/docs/installation stating that the current ErrorProne version 2.19.1 > 2.10.0 was the latest version to support running on JDK 8. So the way forward here is actually NOT to change the change the CI build from Java 11 to 8 (here), but instead to add |
I just learnt that the following ugly warning which I never looked more into:
is actually related to this topic. To fix this, in order to be able to do |
https://errorprone.info/bugpattern/Java8ApiChecker does something similar as well. I'm going to use |
I'll discuss with my team, but I think what's more likely is that we'll focus our energy on getting to JDK11+ so we don't have to keep worrying about this issue! |
@vorburger Hello! Do you mind if I contribute to this issue? I have some idea how this can be implemented |
@vorburger Oh, yes, I see that you have already made changes to this issue, my thought was to add a utility method that repeats the functionality of |
@RenatBl we (with @mosesn) FYI just got rid of that |
@mosesn raised (here) that he uses this library in an environment that is still on on Java 8 ("likely for the next year").
This project is currently targeting Java 11. The README does not explicitly state that (but it should); more imporantly the CI build is on Java here which de facto permits using Java 11 in contributions.
I'm personally very open to contributions to "downgrade" that back to Java 8 again, specifically:
AtomicReference#compareAndExchange()
introduced in Replace DefaultExecuteResultHandler with AtomicExecuteResultHandler #110 to Java 8Would someone reading this like to make such a contribution? @mosesn perhaps?
The text was updated successfully, but these errors were encountered: