changes AtomicExecuteResultHandler to be a thin wrapper around CompletableFuture #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vorburger
requested changes
May 14, 2023
| if (inner instanceof ExecuteException) { | ||
| return Optional.of((ExecuteException) inner); | ||
| } else { | ||
| return Optional.empty(); |
There was a problem hiding this comment.
This should never happen, and would be a bug if it did - agreed? How about something like:
Suggested change
| return Optional.empty(); | |
| throw new IllegalStateException("BUG"); |
There was a problem hiding this comment.
actually @mosesn let me just merge this as-is, and then follow-up with a PR for this...
| } catch (InterruptedException e) { | ||
| throw e; | ||
| } catch (Exception e) { | ||
| // just swallow anything else |
There was a problem hiding this comment.
upon reviewing this, I'm wondering if there was a bug in the original version... after an onProcessFailed(ExecuteException e) I guess we would expect a waitFor() to re-throw that? This won't do that - but nor did it before? Perhaps a unit test would be in order... are you interested to contribute one?
There was a problem hiding this comment.
ah no, I'm just stupid... you would NOT expect that behaviour from a waitFor()
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the chat on a recent PR https://github.com/vorburger/ch.vorburger.exec/pull/110/files#r1193152562
This is a minimally invasive change to illustrate what I was saying about AtomicExecuteResultHandler feeling very similar to CompletableFuture. If I'm feeling up to it, I'll also put up a more invasive PR as an example to show what I meant by fully replacing it with CompletableFuture.