osx friendly tests #135
Merged
osx friendly tests #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ManagedProcessTest relies on the executables that are commonly found on different OSes. Although many of the BSD and Linux executables are similar, they have some minor differences. For example, ls -4 returns with an exit code of 2 on OSX, not 1 like on Linux. Similarly, sleep just takes a number of seconds on OSX, unlike on Linux where it also takes a unit (eg 10s or 10ms).
vorburger
approved these changes
Jun 16, 2023
|
@mosesn I am SO SORRY this "slipped through the cracks" - I just stumbled upon this again today, and am of course very happy to merge it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ManagedProcessTest relies on the executables that are commonly found on different OSes. Although many of the BSD and Linux executables are similar, they have some minor differences. For example, ls -4 returns with an exit code of 2 on OSX, not 1 like on Linux. Similarly, sleep just takes a number of seconds on OSX, unlike on Linux where it also takes a unit (eg 10s or 10ms).
This patch updates the tests to accommodate the different behavior in OSX.