This repository has been archived by the owner on Apr 12, 2019. It is now read-only.
fix (badly) broken build #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because https://git.opendaylight.org/gerrit/#/c/75762/ removed it but the real solution, later, is to replace it with BP annotations.
[ERROR] Failed to execute goal org.apache.aries.blueprint:blueprint-maven-plugin:1.10.0:blueprint-generate (default) on project ds: Execution default of goal org.apache.aries.blueprint:blueprint-maven-plugin:1.10.0:blueprint-generate failed: A required class was missing while executing org.apache.aries.blueprint:blueprint-maven-plugin:1.10.0:blueprint-generate: org/opendaylight/mdsal/dom/api/DOMTransactionChainClosedException
When I originally wrote this code we were in the beginning of Neon; at that time, controller was still dependent on an mdsal SNAPSHOT. Later during Neon we moved to a fixed mdsal version - which this change does. This fixes the following error in org.opendaylight.etcd.testutils.test.EtcdDBTest : java.lang.NoSuchMethodError: org.opendaylight.yangtools.yang.binding.CodeHelpers.wrapperHashCode(Ljava/lang/Object;)I at org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.md.sal.test.list.rev140701.two.level.list.TopLevelListKey.hashCode(TopLevelListKey.java:38)
because 4.0.9 is what we ended up shipping Neon with, so must use that
because infrautils:parent already does spotbugs, no need for findbugs and infrautils:parent already does checkstyle enforcement as well
see https://wiki.opendaylight.org/view/Neon_platform_upgrade#Blueprint_declarations With this the basic broken build and long overdue Neon migration is complete and we are hitting the first (new, this worked before..) "real" bug, see #8 ...
in EtcdDataBrokerRule and TestEtcdDataBrokerProvider
to reproduce #8 except that it doesn't actually reproduce it (needs more models)
until #8 is fixed
I missed these before because I ran with -Dmodernizer.skip
So that the launcher works on Travis CI
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #5