Fixed dependency and compilation issues: #3
Conversation
- invalid version of org.opendaylight.mdsal.binding-parent - README.md - updated 'howto build' - demo projec was no compiling Signed-off-by: Juraj Veverka <juraj.veverka@pantheon.tech>
| @@ -7,14 +7,15 @@ The plan is contribute this to opendaylight.org, if and when successful. | |||
|
|
|||
| ## How to build? | |||
|
|
|||
| If you're hitting an NPE in org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar, | |||
| just use `mvn -Dmaven.javadoc.skip=true clean install` to work around it; it's possibly | |||
| 1. To get a more recent version of jetcd-core than the currently used 0.0.2, just | |||
| @@ -5,7 +5,7 @@ | |||
| <parent> | |||
| <groupId>org.opendaylight.mdsal</groupId> | |||
| <artifactId>binding-parent</artifactId> | |||
| <version>0.13.0-SNAPSHOT</version> | |||
| <version>0.13.1-SNAPSHOT</version> | |||
There was a problem hiding this comment.
LGTM! Let's get this in, but after that we should probably bump it from 0.13.x to 0.14.0-SNAPSHOT and then after neon-mri is in to 0.15.0-SNAPSHOT - I'll try to remember to do both, after this is merged.
| @@ -74,11 +68,12 @@ public static void main(String[] args) throws Exception { | |||
| } | |||
|
|
|||
| private static void dumpMetricsToStdOut(MetricProviderImpl metricProvider) { | |||
| try (PrintWriter pw = new PrintWriter(new BufferedWriter(new OutputStreamWriter(System.out, UTF_8)))) { | |||
| //TODO: rewrite printing of metrics. unfortunately 'getRegistry()' is not implemented in MetricProviderImpl | |||
There was a problem hiding this comment.
oups.. this was supposed to be OK by the time anyone had a closer look... 😸 see https://git.opendaylight.org/gerrit/#/c/76392/ (and also FYI https://git.opendaylight.org/gerrit/#/c/76388/ and https://git.opendaylight.org/gerrit/#/c/76391/) ... can we give that a moment to get merged, and then you could undo this here?
There was a problem hiding this comment.
@jveverka https://git.opendaylight.org/gerrit/#/c/76392/ finally just got merged (sorry for the delay). Do you want to update this PR and undo this part of the change now?
|
@jveverka looks like you didn't have time for / had to drop the ball on this? As per inline review comments, as https://git.opendaylight.org/gerrit/#/c/76392/ is now available, I've reverted the change you proposed to Thanks for contributing - I'm hoping to see more from you! E.g. #4 is certainly welcome. 😄 |
Signed-off-by: Juraj Veverka juraj.veverka@pantheon.tech