Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ProcessCountCheck #32

Merged
merged 3 commits into from
Sep 27, 2023
Merged

add ProcessCountCheck #32

merged 3 commits into from
Sep 27, 2023

Conversation

david-d-h
Copy link
Contributor

@david-d-h david-d-h commented Sep 27, 2023

This PR adds the ProcessCountCheck, it can be configured like this.

OK::checks([
    ProcessCountCheck::config()
        ->setProcessCountThresholds([
            'php' => [
                'max' => 1,
                'exact' => false, // This will match phpstorm as well as the currently running php process.
                                  // Meaning the check will fail in this example. This would also match processes like-
                                  // php-8.1 and php-8.2.
            ],
            'phpstorm' => 1, // The 'exact' option is defaulted to `true`.
        ]),
]);

@david-d-h david-d-h added the enhancement New feature or request label Sep 27, 2023
@david-d-h david-d-h self-assigned this Sep 27, 2023
@markvaneijk
Copy link
Member

De exact boolean kon er nu uit toch? @dulkoss

@david-d-h
Copy link
Contributor Author

david-d-h commented Sep 27, 2023

De exact boolean kon er nu uit toch? @dulkoss

Nee dat kan niet echt, want als je nu php hebt met exact als false dan komt bijvoorbeeld ook PhpStorm tevoorschijn. Als we exact weghalen gebeurt dat altijd

@markvaneijk
Copy link
Member

markvaneijk commented Sep 27, 2023 via email

@david-d-h
Copy link
Contributor Author

Oh ja, dat klopt. Daar had ik niet echt over nagedacht nee, ik zal het even aanpassen.

@markvaneijk
Copy link
Member

Top!

@markvaneijk markvaneijk merged commit 6fcb9f5 into main Sep 27, 2023
@markvaneijk markvaneijk deleted the feature/process-count-check branch September 27, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants