Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add DatabaseTableSizeCheck #37

Merged
merged 4 commits into from
Oct 5, 2023
Merged

add DatabaseTableSizeCheck #37

merged 4 commits into from
Oct 5, 2023

Conversation

david-d-h
Copy link
Contributor

This PR adds the DatabaseTableSizeCheck, it can be configured like this.

OK::checks([
    DatabaseTableSizeCheck::config()
        ->onConnection('mysql')
        ->setTableSizeThresholds([
            'users' => 50,// in megabytes
        ]),
]);

@david-d-h david-d-h added the enhancement New feature or request label Sep 29, 2023
@david-d-h david-d-h self-assigned this Sep 29, 2023
@markvaneijk
Copy link
Member

Goed om in de method zelf duidelijk te maken dat het in Megabytes is: setTableSizeThresholdsInMegabytes

markvaneijk
markvaneijk requested changes Sep 29, 2023
View reviewed changes
Copy link
Member

@markvaneijk markvaneijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kleine aanpassing in de method: setTableSizeThresholds → setTableSizeThresholdsInMegabytes

@markvaneijk
Copy link
Member

markvaneijk commented Oct 3, 2023 •
edited
Loading

Hier zou ik graag nog (net als bij de andere checks) een treshold method voor gigabytes zien. @dulkoss

@markvaneijk markvaneijk merged commit 1682339 into main Oct 5, 2023
7 checks passed
@markvaneijk markvaneijk deleted the feature/table-size-check branch October 5, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markvaneijk markvaneijk markvaneijk requested changes

Assignees

@david-d-h david-d-h

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-d-h @markvaneijk