Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add RebootCheck #38

Merged
merged 6 commits into from
Oct 3, 2023
Merged

add RebootCheck #38

merged 6 commits into from
Oct 3, 2023

Conversation

david-d-h
Copy link
Contributor

This PR adds the RebootCheck, it's much like the UptimeCheck. It can be configured like this.

OK::checks([
    RebootCheck::config()
        ->setMinTimeSinceReboot(Carbon::now()->subHour()),
]);

@david-d-h david-d-h added the enhancement New feature or request label Sep 29, 2023
@david-d-h david-d-h self-assigned this Sep 29, 2023
@david-d-h david-d-h mentioned this pull request Sep 29, 2023
Merged
markvaneijk
markvaneijk requested changes Sep 29, 2023
View reviewed changes
Copy link
Member

@markvaneijk markvaneijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kleine tekst aanpassing (zie feedback) en hoe vaak wordt deze check uitgevoerd en welke tijd moet ik dan invoeren en hoe zorg ik ervoor dat deze melding niet tig keer wordt verzonden?

src/Checks/RebootCheck.php Outdated
$timestamp = $this->getSystemUptime();

if (! isset($this->minTimeSinceReboot)) {
throw new \Exception('The max time since reboot was not set.');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hier staat nog "max"

@markvaneijk
Copy link
Member

@dulkoss deze heeft nog merge conflicts, zou je deze kunnen fixen?

@markvaneijk markvaneijk merged commit cadc63a into main Oct 3, 2023
7 checks passed
@markvaneijk markvaneijk deleted the feature/reboot-check branch October 3, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markvaneijk markvaneijk markvaneijk requested changes

Assignees

@david-d-h david-d-h

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david-d-h @markvaneijk