Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strenum optional dependancy #604

Merged
merged 3 commits into from
Jun 15, 2023

Conversation

Eixalde
Copy link
Contributor

@Eixalde Eixalde commented Jun 15, 2023

Replaced strenum by generic, Python-included Enum support. Works just like before

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2023

Codecov Report

Merging #604 (5f044b3) into master (e578255) will decrease coverage by 1.55%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master     #604      +/-   ##
==========================================
- Coverage   57.91%   56.36%   -1.55%     
==========================================
  Files          66       66              
  Lines       13233    13232       -1     
==========================================
- Hits         7663     7457     -206     
- Misses       5570     5775     +205     
Impacted Files Coverage Δ
vip_hci/objects/pppca.py 69.83% <ø> (ø)
vip_hci/invprob/andromeda.py 10.70% <100.00%> (ø)
vip_hci/invprob/fmmf.py 12.16% <100.00%> (ø)
vip_hci/psfsub/framediff.py 30.23% <100.00%> (ø)
vip_hci/psfsub/llsg.py 20.09% <100.00%> (ø)
vip_hci/psfsub/loci.py 76.70% <100.00%> (ø)
vip_hci/psfsub/medsub.py 77.62% <100.00%> (ø)
vip_hci/psfsub/nmf_fullfr.py 52.15% <100.00%> (ø)
vip_hci/psfsub/nmf_local.py 80.00% <100.00%> (ø)
vip_hci/psfsub/pca_fullfr.py 51.45% <100.00%> (ø)
... and 2 more

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@VChristiaens VChristiaens merged commit a94a910 into vortex-exoplanet:master Jun 15, 2023
@VChristiaens
Copy link
Contributor

Thanks @Eixalde !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants