Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the contrast_curve function more robust to classes with inherited attributes #626

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

JustLatour
Copy link
Contributor

In the contrast curve function, an algorithm using a class with certain specific inherited attributes is not supported. This change makes it more robust to those kinds of algorithms if they need to be used.

@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6028e7e) 55.94% compared to head (20da21c) 22.31%.

Files Patch % Lines
vip_hci/metrics/contrcurve.py 0.00% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #626       +/-   ##
===========================================
- Coverage   55.94%   22.31%   -33.63%     
===========================================
  Files          67       67               
  Lines       13535    13535               
===========================================
- Hits         7572     3020     -4552     
- Misses       5963    10515     +4552     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VChristiaens VChristiaens merged commit 5785214 into vortex-exoplanet:master Dec 18, 2023
14 checks passed
@JustLatour JustLatour deleted the ContrastDir branch March 10, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants