Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inclusion of IROLL, IPCA, NEGFD routines and new features to NEGFC routines #628

Merged
merged 96 commits into from
Mar 19, 2024

Conversation

VChristiaens
Copy link
Contributor

Additional changes:

  • new options for speckle-based and cross-correlation based recentering routines;
  • updated automated tests
  • bug fix related to left eigenvectors in pca_annular
  • more complete docstrings

…ffect of transmission when injecting fake disks
…pass filtering - i.e. just log-scale recentering
…ort to report by default the highest SNR feature when no source position provided
… bug associated to phase_cross_correlation function - used in cube_recenter_dft_upsampling and cube_recenter_via_speckles
…kit-image's phase_ccross_correlation function is avoided
…igenvectors - instead of just the right eigenvectors
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 18.36420% with 1587 lines in your changes are missing coverage. Please review.

Project coverage is 34.77%. Comparing base (8c3268e) to head (2fca4a0).

Files Patch % Lines
vip_hci/fm/negfd_simplex.py 4.56% 293 Missing ⚠️
vip_hci/greedy/ipca_fullfr.py 0.00% 238 Missing ⚠️
vip_hci/greedy/inmf_fullfr.py 0.00% 236 Missing ⚠️
vip_hci/fm/negfd_fmerit.py 5.97% 126 Missing ⚠️
vip_hci/greedy/iroll.py 0.00% 87 Missing ⚠️
vip_hci/fm/negfd_interp.py 7.78% 83 Missing ⚠️
vip_hci/psfsub/rollsub.py 25.89% 83 Missing ⚠️
vip_hci/fm/utils_negfd.py 8.43% 76 Missing ⚠️
vip_hci/preproc/recentering.py 55.12% 57 Missing ⚠️
vip_hci/preproc/rescaling.py 60.90% 52 Missing ⚠️
... and 22 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #628       +/-   ##
===========================================
- Coverage   57.46%   34.77%   -22.69%     
===========================================
  Files          67       87       +20     
  Lines       13535    16365     +2830     
===========================================
- Hits         7777     5690     -2087     
- Misses       5758    10675     +4917     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VChristiaens VChristiaens merged commit d9f1bef into vortex-exoplanet:master Mar 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants