Add back the "ecall" and "ebreak" instruction traps for riscv-vector test functionality #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or tests run properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit
f8ef5707780905991f81fbb89ee30d2462c6722d, the instructionsecallandebreakhad their trap removed from simx, causing any vector tests that use these instructions to have incorrect and undefined behavior (as the tests would pass over these instructions and continue execution past the intended point).Therefore, at least for the foreseeable future, the traps for these instructions should be added back so that riscv-vector tests properly execute.