Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector extension simx with fallbacks for testcases and clean history #211

Merged
merged 8 commits into from
Dec 5, 2024

Conversation

MichaelJSr
Copy link
Contributor

Massive thanks to Troibe for his amazing work on the vector extension!

This is a fork of his work that has been updated to be up-to-date with the master branch, as well as adding regression testing, a bit more debug logging, and a few other modifications.

This pull request does not have the large vector testcases in the repository/history, and instead will download/copy the testcases from the submodule on demand. I was not sure how to remove only the commits from the history that added/modified the vector testcases without causing more issues, which is why this branch only has a single commit with just the changes. I will leave the previous branch(es) that have this history open in my fork just in case this history is needed. I hope this is acceptable, thanks in advance!

@MichaelJSr
Copy link
Contributor Author

@troibe I don't have git permissions to manually add you as a reviewer to this pull request, but as always any feedback/requested changes are appreciated!

@MichaelJSr MichaelJSr marked this pull request as draft November 28, 2024 07:57
@MichaelJSr MichaelJSr marked this pull request as ready for review November 29, 2024 06:19
@tinebp tinebp merged commit 5d91fe5 into vortexgpgpu:master Dec 5, 2024
3 checks passed
@MichaelJSr MichaelJSr deleted the riscv-vector-isa-simx-clean branch December 5, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants