Kent/agora 2553 spike an orchestrator testing pattern #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jefag
force-pushed
the
kent/agora-2553-spike-an-orchestrator-testing-pattern
branch
from
694433c to
930afe9
Compare
jefag
commented
Oct 11, 2024
Comment on lines
+1
to
+5
| export function setEnv(envConfig: { [key: string]: string }) { | ||
| Object.keys(envConfig).forEach((key) => { | ||
| process.env[key] = envConfig[key]; | ||
| }); | ||
| } |
There was a problem hiding this comment.
Is this being called somewhere? What is invoking this? I don't see it.
There was a problem hiding this comment.
FWIW, I'm not asking because I'm worried about about dead code. I'm asking, because a key part of this is how we're managing the sets of environment variables in the orchestrator.
jefag
commented
Oct 11, 2024
|
|
||
| // Main loop for test runner | ||
| async function main() { | ||
| const config: Config = loadConfig() as Config; |
There was a problem hiding this comment.
I would have expected a tenant-config.yaml to load a single tenant's configuration. Not a set of tenants.
The orchestrator could optionally take a list, and loop over each of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.