Revert batch tally sheet generation since @react-pdf/renderer would require us to relax our CSP #1481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙈 🙉 🙊 |
jonahkagan
approved these changes
May 12, 2022
arsalansufi
deleted the
revert-1475-1437-generate-batch-tally-sheets-for-hand-record-keeping
branch
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1475
Alas, it was too good to be true. @react-pdf/renderer's dependencies use
evalinternally and would require us to relax our CSP policy. This is a deal breaker for us (and has been for others as well - see diegomura/react-pdf#510). We didn't catch this during local development because we're not setting the same strict CSP on localhost. (A separate issue for us to explore, though setting a strict CSP on localhost may be hard.)We can roll this change back out with another PDF generation tool, potentially the jsPDF library that we're already using in Arlo.
More context in this Slack thread: https://votingworks.slack.com/archives/CKCVA0F9S/p1652317620466379