Merge pull request #128 from votingworks/fix/show-invalid-test-mode-s…

…heet-correctly fix: show invalid test mode pages correctly
votingworks · Oct 13, 2020 · 33e1df9 · 33e1df9
2 parents 71b40a3 + acc52ff
commit 33e1df9
Show file tree

Hide file tree

Showing 4 changed files with 365 additions and 54 deletions.
diff --git a/src/AppRoot.tsx b/src/AppRoot.tsx
@@ -358,7 +358,12 @@ const App: React.FC = () => {
 
   if (election) {
     if (adjudication.remaining > 0 && !isScanning) {
-      return <BallotEjectScreen continueScanning={continueScanning} />
+      return (
+        <BallotEjectScreen
+          continueScanning={continueScanning}
+          isTestMode={isTestMode}
+        />
+      )
     }
 
     return (

diff --git a/src/screens/BallotEjectScreen.test.tsx b/src/screens/BallotEjectScreen.test.tsx
@@ -23,7 +23,7 @@ test('says the sheet is unreadable if it is', async () => {
   const continueScanning = jest.fn()
 
   const { container, getByText } = render(
-    <BallotEjectScreen continueScanning={continueScanning} />
+    <BallotEjectScreen continueScanning={continueScanning} isTestMode />
   )
 
   await act(async () => {
@@ -109,7 +109,7 @@ test('says the ballot sheet is overvoted if it is', async () => {
   const continueScanning = jest.fn()
 
   const { container, getByText } = render(
-    <BallotEjectScreen continueScanning={continueScanning} />
+    <BallotEjectScreen continueScanning={continueScanning} isTestMode />
   )
 
   await act(async () => {
@@ -188,7 +188,7 @@ test('says the ballot sheet is blank if it is', async () => {
   const continueScanning = jest.fn()
 
   const { container, getByText } = render(
-    <BallotEjectScreen continueScanning={continueScanning} />
+    <BallotEjectScreen continueScanning={continueScanning} isTestMode />
   )
 
   await act(async () => {
@@ -207,3 +207,107 @@ test('says the ballot sheet is blank if it is', async () => {
   fireEvent.click(getByText('Tabulate Ballot and Continue Scanning'))
   expect(continueScanning).toHaveBeenCalledWith(true)
 })
+
+test('calls out live ballot sheets in test mode', async () => {
+  const response: BallotSheetInfo = {
+    id: 'mock-sheet-id',
+    front: {
+      image: { url: '/front/url' },
+      interpretation: {
+        type: 'InvalidTestModePage',
+        metadata: {
+          ballotStyleId: '1',
+          precinctId: '1',
+          ballotType: BallotType.Standard,
+          electionHash: '',
+          isTestMode: false,
+          locales: { primary: 'en-US' },
+          pageNumber: 1,
+        },
+      },
+    },
+    back: {
+      image: { url: '/back/url' },
+      interpretation: {
+        type: 'InvalidTestModePage',
+        metadata: {
+          ballotStyleId: '1',
+          precinctId: '1',
+          ballotType: BallotType.Standard,
+          electionHash: '',
+          isTestMode: false,
+          locales: { primary: 'en-US' },
+          pageNumber: 2,
+        },
+      },
+    },
+  }
+  fetchMock.getOnce('/scan/hmpb/review/next-sheet', response)
+
+  const continueScanning = jest.fn()
+
+  const { container, getByText } = render(
+    <BallotEjectScreen continueScanning={continueScanning} isTestMode />
+  )
+
+  await act(async () => {
+    await waitFor(() => fetchMock.called)
+  })
+
+  expect(container).toMatchSnapshot()
+
+  fireEvent.click(getByText('Confirm Ballot Removed and Continue Scanning'))
+  expect(continueScanning).toHaveBeenCalledWith()
+})
+
+test('calls out test ballot sheets in live mode', async () => {
+  const response: BallotSheetInfo = {
+    id: 'mock-sheet-id',
+    front: {
+      image: { url: '/front/url' },
+      interpretation: {
+        type: 'InvalidTestModePage',
+        metadata: {
+          ballotStyleId: '1',
+          precinctId: '1',
+          ballotType: BallotType.Standard,
+          electionHash: '',
+          isTestMode: false,
+          locales: { primary: 'en-US' },
+          pageNumber: 1,
+        },
+      },
+    },
+    back: {
+      image: { url: '/back/url' },
+      interpretation: {
+        type: 'InvalidTestModePage',
+        metadata: {
+          ballotStyleId: '1',
+          precinctId: '1',
+          ballotType: BallotType.Standard,
+          electionHash: '',
+          isTestMode: false,
+          locales: { primary: 'en-US' },
+          pageNumber: 2,
+        },
+      },
+    },
+  }
+  fetchMock.getOnce('/scan/hmpb/review/next-sheet', response)
+
+  const continueScanning = jest.fn()
+
+  const { container, getByText } = render(
+    <BallotEjectScreen continueScanning={continueScanning} isTestMode={false} />
+  )
+
+  await act(async () => {
+    await waitFor(() => fetchMock.called)
+  })
+
+  expect(container).toMatchSnapshot()
+
+  fireEvent.click(getByText('Confirm Ballot Removed and Continue Scanning'))
+  expect(continueScanning).toHaveBeenCalledWith()
+})
diff --git a/src/screens/BallotEjectScreen.tsx b/src/screens/BallotEjectScreen.tsx
@@ -48,6 +48,7 @@ const RectoVerso = styled.div`
 
 interface Props {
   continueScanning: (override?: boolean) => void
+  isTestMode: boolean
 }
 
 type EjectState = undefined | 'removeBallot' | 'acceptBallot'
@@ -56,7 +57,7 @@ const doNothing = () => {
   console.log('disabled') // eslint-disable-line no-console
 }
 
-const BallotEjectScreen = ({ continueScanning }: Props) => {
+const BallotEjectScreen = ({ continueScanning, isTestMode }: Props) => {
   const [sheetInfo, setSheetInfo] = useState<BallotSheetInfo | undefined>()
 
   const [ballotState, setBallotState] = useState<EjectState>(undefined)
@@ -74,9 +75,12 @@ const BallotEjectScreen = ({ continueScanning }: Props) => {
   let isOvervotedSheet = false
   let isBlankSheet = false
   let isUnreadableSheet = false
+  let isInvalidTestModeSheet = false
 
   for (const { interpretation } of [sheetInfo.front, sheetInfo.back]) {
-    if (interpretation.type === 'InterpretedHmpbPage') {
+    if (interpretation.type === 'InvalidTestModePage') {
+      isInvalidTestModeSheet = true
+    } else if (interpretation.type === 'InterpretedHmpbPage') {
       if (interpretation.adjudicationInfo.requiresAdjudication) {
         for (const { type } of interpretation.adjudicationInfo.allReasonInfos) {
           if (interpretation.adjudicationInfo.enabledReasons.includes(type)) {
@@ -96,7 +100,11 @@ const BallotEjectScreen = ({ continueScanning }: Props) => {
   return (
     <Screen>
       <MainNav>
-        {ballotState === 'removeBallot' ? (
+        {isInvalidTestModeSheet ? (
+          <Button primary onPress={() => continueScanning()}>
+            Confirm Ballot Removed and Continue Scanning
+          </Button>
+        ) : ballotState === 'removeBallot' ? (
           <Button primary onPress={() => continueScanning()}>
             Confirm Ballot Removed and Continue Scanning
           </Button>
@@ -115,7 +123,11 @@ const BallotEjectScreen = ({ continueScanning }: Props) => {
           <Columns>
             <Prose maxWidth={false}>
               <EjectReason>
-                {isUnreadableSheet
+                {isInvalidTestModeSheet
+                  ? isTestMode
+                    ? 'Live Ballot'
+                    : 'Test Ballot'
+                  : isUnreadableSheet
                   ? 'Unreadable'
                   : isOvervotedSheet
                   ? 'Overvote'
@@ -126,52 +138,60 @@ const BallotEjectScreen = ({ continueScanning }: Props) => {
               <p>
                 This last scanned sheet <strong>was not tabulated</strong>.
               </p>
-              <h4>Original Ballot Scan</h4>
-              <p>
-                Remove ballot and create a duplicate ballot for the Resolution
-                Board to review.
-                <br />
-                <Button
-                  primary={ballotState === 'removeBallot'}
-                  onPress={() => setBallotState('removeBallot')}
-                >
-                  Original Ballot Removed
-                </Button>
-              </p>
-              <h4>Duplicate Ballot Scan</h4>
-              <p>
-                {isUnreadableSheet ? (
-                  <React.Fragment>
-                    Confirm sheet was reviewed by the Resolution Board and
-                    tabulate as <strong>unreadable</strong>.
-                  </React.Fragment>
-                ) : isOvervotedSheet ? (
-                  <React.Fragment>
-                    Confirm ballot sheet was reviewed by the Resolution Board
-                    and tabulate as ballot sheet with an{' '}
-                    <strong>overvote</strong>.
-                  </React.Fragment>
-                ) : isBlankSheet ? (
-                  <React.Fragment>
-                    Confirm ballot sheet was reviewed by the Resolution Board
-                    and tabulate as a <strong>blank</strong> ballot sheet and
-                    has no votes.
-                  </React.Fragment>
-                ) : (
-                  <React.Fragment>
-                    Confirm ballot sheet was reviewed by the Resolution Board
-                    and tabulate as ballow with issue which could not be
-                    determined.
-                  </React.Fragment>
-                )}
-                <br />
-                <Button
-                  primary={ballotState === 'acceptBallot'}
-                  onPress={() => setBallotState('acceptBallot')}
-                >
-                  Tabulate Duplicate Ballot
-                </Button>
-              </p>
+              {!isInvalidTestModeSheet ? (
+                <React.Fragment>
+                  <h4>Original Ballot Scan</h4>
+                  <p>
+                    Remove ballot and create a duplicate ballot for the
+                    Resolution Board to review.
+                    <br />
+                    <Button
+                      primary={ballotState === 'removeBallot'}
+                      onPress={() => setBallotState('removeBallot')}
+                    >
+                      Original Ballot Removed
+                    </Button>
+                  </p>
+                  <h4>Duplicate Ballot Scan</h4>
+                  <p>
+                    {isUnreadableSheet ? (
+                      <React.Fragment>
+                        Confirm sheet was reviewed by the Resolution Board and
+                        tabulate as <strong>unreadable</strong>.
+                      </React.Fragment>
+                    ) : isOvervotedSheet ? (
+                      <React.Fragment>
+                        Confirm ballot sheet was reviewed by the Resolution
+                        Board and tabulate as ballot sheet with an{' '}
+                        <strong>overvote</strong>.
+                      </React.Fragment>
+                    ) : isBlankSheet ? (
+                      <React.Fragment>
+                        Confirm ballot sheet was reviewed by the Resolution
+                        Board and tabulate as a <strong>blank</strong> ballot
+                        sheet and has no votes.
+                      </React.Fragment>
+                    ) : (
+                      <React.Fragment>
+                        Confirm ballot sheet was reviewed by the Resolution
+                        Board and tabulate as ballow with issue which could not
+                        be determined.
+                      </React.Fragment>
+                    )}
+                    <br />
+                    <Button
+                      primary={ballotState === 'acceptBallot'}
+                      onPress={() => setBallotState('acceptBallot')}
+                    >
+                      Tabulate Duplicate Ballot
+                    </Button>
+                  </p>
+                </React.Fragment>
+              ) : isTestMode ? (
+                <p>Remove the LIVE ballot before continuing.</p>
+              ) : (
+                <p>Remove the TEST ballot before continuing.</p>
+              )}
             </Prose>
             <RectoVerso>
               <div>