This repository has been archived by the owner on Oct 29, 2020. It is now read-only.
build: upgrade react-scripts to v4 #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also updates to React 17, eslint 7, TypeScript v4, etc. - React 17 has no new features, but does have a few breaking changes that shouldn't affect bsd. (https://reactjs.org/blog/2020/10/20/react-v17.html) - eslint 7 and the updated config caused a minor issue (https://stackoverflow.com/a/64024916/549363) - react-scripts v4 seems to have a bug while validating TS config, which this commit works around (facebook/create-react-app#9429)
benadida
approved these changes
Oct 23, 2020
Adds `type-fest` to replace my `DeepReadonly` type, and possibly more over time.
|
FWIW @beausmith, I tried this on BMD too and it was not as straightforward. Test failures without an obvious cause. I'm sure we can figure it out though. |
These were being treated as errors in CI.
|
Deploy preview for vw-bsd ready! Built with commit aa8f3ef |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also updates to React 17, eslint 7, TypeScript v4, etc.