Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(router): replace withRouter with hooks #1122

Merged
merged 1 commit into from
Nov 1, 2021
Merged

refactor(router): replace withRouter with hooks #1122

merged 1 commit into from
Nov 1, 2021

Commits on Oct 28, 2021

  1. refactor(router): replace withRouter with hooks 

    `react-router-dom` has `withRouter` that passes information via a higher-order component. This is fine, but it has fairly complex types that TS is only happy with when it's a default export. When we change to using named exports this will cause a build error. See microsoft/TypeScript#42873.
    @eventualbuddha
    eventualbuddha committed Oct 28, 2021
    Configuration menu
    Copy the full SHA
    a2551df View commit details
    Browse the repository at this point in the history