Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extraEnvVars to support secret values #33

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

riteshpradhan
Copy link

This allows importing values directly from secret.

Example:

---
extraEnvVars:
  - name: HTTPS_PROXY
    value: "https://example.com"
  - name: SECRET_VALUE
    valueFrom:
      secretKeyRef:
        name: my-secrets
        key: password

@CoolDuke
Copy link

CoolDuke commented Sep 7, 2023

This is actual the solution to read a client secret from a key vault (connected via CSI driver) while the other settings are defined as plain-text values. The current approach treating the whole config as a secret prevents this.

Would be great if someone could approve this PR and release a new helm chart version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants