Change logrus imports to lowercase #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imports should use the lowercase sirupsen. See paragraph two of their README.
artagel
changed the title
|
Thanks for the contribution @artagel I've just spent a little time ripping out logrus and installing zap https://github.com/uber-go/zap on a feature branch. Zap seems more performant and I'm a just a bit concerned by the message on Logrus asking for help. Would you care to take a look at this? I'd love to get another set of eyes on it.. |
|
Sure. I’ll review it in the next day |
|
I need to actually run the code, but overall my only comment is why use logger in some places and log in others. A standard variable would be better. |
|
I took a look, yeah I like it. |
bnfinet
added a commit
that referenced
this pull request
May 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see issue 933 on logrus project (sirupsen/logrus#933).
According to their readme:
Seeing weird case-sensitive problems? It's in the past been possible to import Logrus as both upper- and lower-case. Due to the Go package environment, this caused issues in the community and we needed a standard. Some environments experienced problems with the upper-case variant, so the lower-case was decided. Everything using logrus will need to use the lower-case: github.com/sirupsen/logrus. Any package that isn't, should be changed.The uppercase was causing errors building and running vouch due to their use of internal packages. The fix is to use the proper lowercase import as they described in their readme.