Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select language according to http accept-language parameter #73

Merged
merged 2 commits into from
Jun 9, 2013

Conversation

Soulou
Copy link
Contributor

@Soulou Soulou commented Apr 3, 2013

There a layout issue with the french locale, the logo is on the text :

Capture du 2013-04-03 18:18:10

@NebJ
Copy link
Member

NebJ commented Apr 4, 2013

Well done @Soulou ! @edschlum what do you think about the french header, we should rename one or two menu to fit in it?

@edschlum
Copy link
Member

edschlum commented Apr 4, 2013

I can't see the French header right now. Is there anything new on staging ? Thx :)

@Soulou
Copy link
Contributor Author

Soulou commented Apr 4, 2013

@edschlum Sorry, I hadn't deployed it on staging, it's done now =)

@edschlum
Copy link
Member

edschlum commented Apr 4, 2013

thanks @Soulou !
French Header : I suggest something like this : http://cl.ly/image/3h1E0h0w2Y3N

English header : replace "Connexion" by "Log in".

The header must be the same on any page.

Thx!

@Soulou
Copy link
Contributor Author

Soulou commented Apr 4, 2013

Capture du 2013-04-04 14:40:48
Capture du 2013-04-04 14:41:11

@edschlum
Copy link
Member

edschlum commented Apr 4, 2013

Thx @Soulou . Later, we'll have to add a link "Candidate", which links to the backoffice landing page, with subscription option and login.

@Soulou
Copy link
Contributor Author

Soulou commented Apr 4, 2013

I think that for the English version, it won't be a problem, but for the French one, it may be too close from the logo.

@edschlum
Copy link
Member

edschlum commented Apr 4, 2013

True. In that case, we'll move "Hackathon" from the header to the vertical menu here : http://staging.voxe.org/about .

Soulou added a commit that referenced this pull request Jun 9, 2013
Select language according to http accept-language parameter
@Soulou Soulou merged commit 4c20fdc into voxe:develop Jun 9, 2013
@Soulou
Copy link
Contributor Author

Soulou commented Jun 9, 2013

http://staging.voxe.org/ may be French or English now ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants