Make ImageView clickable/linkable in Python Panels #5940
pr.yml
on: pull_request
Matrix: test / test-python
build
/
changes
31s
build
/
build
4m 1s
lint
/
eslint
2m 46s
test
/
test-app
2m 57s
e2e
/
test-e2e
48m 33s
teams
0s
all-tests
0s
Annotations
11 errors, 23 warnings, and 1 notice
[chromium] › oss/specs/grid-tagging.spec.ts:42:1 › grid tagging:
e2e-pw/src/oss/specs/grid-tagging.spec.ts#L1
1) [chromium] › oss/specs/grid-tagging.spec.ts:42:1 › grid tagging ───────────────────────────────
Test timeout of 60000ms exceeded.
|
[chromium] › oss/specs/grid-tagging.spec.ts:42:1 › grid tagging:
e2e-pw/src/oss/poms/grid/index.ts#L70
1) [chromium] › oss/specs/grid-tagging.spec.ts:42:1 › grid tagging ───────────────────────────────
Error: locator.scrollIntoViewIfNeeded: Test timeout of 60000ms exceeded.
Call log:
- attempting scroll into view action
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #1
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #2
- waiting 20ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #3
- waiting 100ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #4
- waiting 100ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #5
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #6
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #7
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #8
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #9
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #10
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #11
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #12
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #13
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #14
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #15
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #16
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #17
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #18
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #19
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #20
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #21
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #22
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #23
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #24
- waiting 500ms
- waiting for element to be stable
- element is not visible
- retrying scroll into view action, attempt #25
- waiting 500ms
- waiting for element to be stable
|
[chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › pcd dynamic group pagination bar:
e2e-pw/src/oss/specs/groups/dynamic-groups.spec.ts#L1
2) [chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › pcd dynamic group pagination bar ──
Test timeout of 60000ms exceeded.
|
[chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › pcd dynamic group pagination bar:
e2e-pw/src/oss/poms/grid/index.ts#L55
2) [chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › pcd dynamic group pagination bar ──
Error: locator.click: Test timeout of 60000ms exceeded.
Call log:
- waiting for getByTestId('fo-grid').getByTestId('looker').first()
- locator resolved to <div tabindex="-1" data-cy="looker" class="_looker_1i9j2_16"></div>
- attempting click action
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <canvas width="914" height="569" canvas-loaded="true" data-engine="three.js r169"></canvas> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #1
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker3d" class="_loading_1wcd9_1">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #2
- waiting 20ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker3d" class="_loading_1wcd9_1">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #3
- waiting 100ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker3d" class="_loading_1wcd9_1">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #4
- waiting 100ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker3d" class="_loading_1wcd9_1">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #5
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker3d" class="_loading_1wcd9_1">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #6
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker3d" class="_loading_1wcd9_1">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #7
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker3d" class="_loading_1wcd9_1">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #8
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker3d" class="_loading_1wcd9_1">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #9
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-
|
[chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › png dynamic group pagination bar:
e2e-pw/src/oss/specs/groups/dynamic-groups.spec.ts#L1
3) [chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › png dynamic group pagination bar ──
Test timeout of 60000ms exceeded.
|
[chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › png dynamic group pagination bar:
e2e-pw/src/oss/poms/grid/index.ts#L55
3) [chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › png dynamic group pagination bar ──
Error: locator.click: Test timeout of 60000ms exceeded.
Call log:
- waiting for getByTestId('fo-grid').getByTestId('looker').first()
- locator resolved to <div tabindex="-1" data-cy="looker" title="Click to expand" class="_looker_1i9j2_16">…</div>
- attempting click action
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div tabindex="-1" data-cy="looker" class="_looker_1i9j2_16">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #1
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div tabindex="-1" data-cy="looker" class="_looker_1i9j2_16">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #2
- waiting 20ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker-error-info" class="_lookerErrorPage_sfdgp_5">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #3
- waiting 100ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker-error-info" class="_lookerErrorPage_sfdgp_5">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #4
- waiting 100ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker-error-info" class="_lookerErrorPage_sfdgp_5">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #5
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker-error-info" class="_lookerErrorPage_sfdgp_5">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #6
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker-error-info" class="_lookerErrorPage_sfdgp_5">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #7
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker-error-info" class="_lookerErrorPage_sfdgp_5">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #8
- waiting 500ms
- waiting for element to be visible, enabled and stable
- element is visible, enabled and stable
- scrolling into view if needed
- done scrolling
- <div data-cy="looker-error-info" class="_lookerErrorPage_sfdgp_5">…</div> from <div id="modal" class="modalon">…</div> subtree intercepts pointer events
- retrying click action, attempt #9
- waiting 500ms
- waiting for element to be visible, enabled and stable
|
[chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › mp4 second slice:
e2e-pw/src/oss/poms/grid/index.ts#L149
4) [chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › mp4 second slice ───────────────────
TimeoutError: page.waitForFunction: Timeout 2000ms exceeded.
at oss/poms/grid/index.ts:149
147 |
148 | async isEntryCountTextEqualTo(text: string) {
> 149 | return this.gridPom.page.waitForFunction(
| ^
150 | (text_) => {
151 | return (
152 | document.querySelector("[data-cy='entry-counts']").textContent ===
at GridAsserter.isEntryCountTextEqualTo (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/grid/index.ts:149:30)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/groups/sparse-groups.spec.ts:103:23
|
[chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › png second slice:
e2e-pw/src/oss/poms/grid/index.ts#L149
5) [chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › png second slice ───────────────────
TimeoutError: page.waitForFunction: Timeout 2000ms exceeded.
at oss/poms/grid/index.ts:149
147 |
148 | async isEntryCountTextEqualTo(text: string) {
> 149 | return this.gridPom.page.waitForFunction(
| ^
150 | (text_) => {
151 | return (
152 | document.querySelector("[data-cy='entry-counts']").textContent ===
at GridAsserter.isEntryCountTextEqualTo (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/grid/index.ts:149:30)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/groups/sparse-groups.spec.ts:103:23
|
[chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice:
e2e-pw/src/oss/poms/modal/index.ts#L314
6) [chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice
Error: expect(received).toBe(expected) // Object.is equality
Expected: "📌 v1"
Received: "📌 v2"
at oss/poms/modal/index.ts:314
312 | const actualTitle = await this.modalPom.modalSamplePluginTitle;
313 | const expectedTitle = pinned ? `📌 ${title}` : title;
> 314 | expect(actualTitle).toBe(expectedTitle);
| ^
315 | }
316 | }
317 |
at ModalAsserter.verifyModalSamplePluginTitle (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/poms/modal/index.ts:314:25)
at checkVideo (/home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/group-video/group-video-label.spec.ts:98:7)
at /home/runner/work/fiftyone/fiftyone/e2e-pw/src/oss/specs/regression-tests/group-video/group-video-label.spec.ts:121:5
|
[chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page:
e2e-pw/src/oss/specs/regression-tests/index-page.spec.ts#L1
7) [chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page ──────────────────
Test timeout of 60000ms exceeded.
|
e2e / test-e2e:
e2e-pw/src/oss/specs/regression-tests/sidebar/sidebar-datetime.spec.ts#L74
'grid' is defined but never used
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L40
React Hook useEffect has missing dependencies: 'panelId', 'panelName', 'setPanelCloseEffect', and 'trackEvent'. Either include them or remove the dependency array
|
lint / eslint:
app/packages/operators/src/CustomPanel.tsx#L104
React Hook useEffect has a missing dependency: 'dimensions'. Either include it or remove the dependency array
|
lint / eslint:
app/packages/operators/src/built-in-operators.ts#L815
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
lint / eslint
'path' is never reassigned. Use 'const' instead
|
lint / eslint
'value' is never reassigned. Use 'const' instead
|
lint / eslint
'ctx' is defined but never used. Allowed unused args must match /^_/u
|
test / test-python (ubuntu-latest-m, 3.10)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.9)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
test / test-python (ubuntu-latest-m, 3.11)
Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1
|
test / test-python (ubuntu-latest-m, 3.11)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only', 'save-always']
|
Slow Test:
e2e-pw/[chromium] › oss/specs/smoke-tests/field-visibility.spec.ts#L1
e2e-pw/[chromium] › oss/specs/smoke-tests/field-visibility.spec.ts took 56.2s
|
Slow Test:
e2e-pw/[chromium] › oss/specs/smoke-tests/saved-views.spec.ts#L1
e2e-pw/[chromium] › oss/specs/smoke-tests/saved-views.spec.ts took 25.4s
|
Slow Test:
e2e-pw/[chromium] › oss/specs/operators/prompt.spec.ts#L1
e2e-pw/[chromium] › oss/specs/operators/prompt.spec.ts took 19.9s
|
Slow Test:
e2e-pw/[chromium] › oss/specs/sidebar/sidebar.spec.ts#L1
e2e-pw/[chromium] › oss/specs/sidebar/sidebar.spec.ts took 18.1s
|
Slow Test:
e2e-pw/[chromium] › oss/specs/selection.spec.ts#L1
e2e-pw/[chromium] › oss/specs/selection.spec.ts took 17.0s
|
e2e / test-e2e
Unexpected input(s) 'working-directory', valid inputs are ['path', 'key', 'restore-keys', 'upload-chunk-size', 'enableCrossOsArchive', 'fail-on-cache-miss', 'lookup-only', 'save-always']
|
e2e / test-e2e
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
e2e / test-e2e:
e2e-pw/src/oss/specs/regression-tests/media-field.spec.ts#L78
Unexpected use of the `.skip()` annotation
|
🎭 Playwright Run Summary
13 flaky
[chromium] › oss/specs/grid-tagging.spec.ts:42:1 › grid tagging ────────────────────────────────
[chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › pcd dynamic group pagination bar ───
[chromium] › oss/specs/groups/dynamic-groups.spec.ts:70:3 › png dynamic group pagination bar ───
[chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › mp4 second slice ────────────────────
[chromium] › oss/specs/groups/sparse-groups.spec.ts:96:3 › png second slice ────────────────────
[chromium] › oss/specs/regression-tests/group-video/group-video-label.spec.ts:87:3 › groups video labels › video plays with correct label for each slice
[chromium] › oss/specs/regression-tests/index-page.spec.ts:24:1 › index page ───────────────────
[chromium] › oss/specs/smoke-tests/embeddings.spec.ts:62:3 › embeddings on quickstart dataset › lasso samples work
[chromium] › oss/specs/smoke-tests/quickstart-groups.spec.ts:79:5 › quickstart-groups › modal › navigation works
[chromium] › oss/specs/smoke-tests/quickstart-groups.spec.ts:104:5 › quickstart-groups › modal › group media visibility toggle works
[chromium] › oss/specs/smoke-tests/quickstart-groups.spec.ts:139:3 › quickstart-groups › modal with grid filter
[chromium] › oss/specs/smoke-tests/quickstart.spec.ts:63:3 › quickstart › entry counts text when toPatches then groupedBy
[chromium] › oss/specs/smoke-tests/quickstart.spec.ts:80:3 › quickstart › selection bookmark ───
2 skipped
90 passed (20.1m)
|
Artifacts
Produced during runtime
Name | Size | |
---|---|---|
dist
|
19.8 MB |
|
playwright-report
|
65.2 MB |
|