update scroll reader

voxel51 · Oct 30, 2024 · 1f27c30 · 1f27c30
1 parent a9f95e5
commit 1f27c30
Showing 1 changed file with 10 additions and 5 deletions.
diff --git a/app/packages/spotlight/src/createScrollReader.ts b/app/packages/spotlight/src/createScrollReader.ts
@@ -15,14 +15,17 @@ export default function createScrollReader(
   let timeout: ReturnType<typeof setTimeout>;
   let zooming = false;
 
-  element.addEventListener("scroll", () => {
+  const scroll = () => {
     scrolling = true;
-  });
+  };
+  element.addEventListener("scroll", scroll);
 
-  element.addEventListener("scrollend", () => {
+  const scrollEnd = () => {
     scrolling = false;
     requestAnimationFrame(() => render(zooming, true));
-  });
+  };
+
+  element.addEventListener("scrollend", scrollEnd);
 
   const updateScrollStatus = () => {
     const threshold = getScrollSpeedThreshold();
@@ -68,7 +71,9 @@ export default function createScrollReader(
   return {
     destroy: () => {
       destroyed = true;
+      element.removeEventListener("scroll", scroll);
+      element.removeEventListener("scrollend", scrollEnd)
     },
-    zooming: () => zooming
+    zooming: () => zooming,
   };
 }