minor improvements

voxel51 · Oct 18, 2024 · 66daf79 · 66daf79
1 parent b095575
commit 66daf79
Show file tree

Hide file tree

Showing 3 changed files with 52 additions and 11 deletions.
diff --git a/app/packages/components/src/components/PillBadge/PillBadge.tsx b/app/packages/components/src/components/PillBadge/PillBadge.tsx
@@ -18,6 +18,7 @@ const PillBadge = ({
   ) => {
     if (typeof text === "string") return text;
     if (Array.isArray(text)) {
+      if (text.length === 0) return "";
       if (Array.isArray(text[0])) return text[0][0];
       return text[0];
     }
@@ -30,6 +31,7 @@ const PillBadge = ({
   ) => {
     if (typeof text === "string") return color;
     if (Array.isArray(text)) {
+      if (text.length === 0) return "default";
       if (Array.isArray(text[0])) return text[0][1];
       return color || "default";
     }
@@ -87,7 +89,9 @@ const PillBadge = ({
               ) : undefined
             }
             label={
-              Array.isArray(text) && text.length > 0 && Array.isArray(text[0]) ? (
+              Array.isArray(text) &&
+              text.length > 0 &&
+              Array.isArray(text[0]) ? (
                 <Select
                   value={chipSelection}
                   variant={"standard"}

diff --git a/app/packages/core/src/plugins/SchemaIO/components/SliderView.tsx b/app/packages/core/src/plugins/SchemaIO/components/SliderView.tsx
@@ -74,7 +74,6 @@ export default function SliderView(props) {
   const focus = autoFocus(props);
 
   const {
-    type,
     min: schemaMin,
     max: schemaMax,
     multipleOf: schemaMultipleOf,
@@ -131,7 +130,7 @@ export default function SliderView(props) {
       }
     } else {
       const floatValue = parseFloat(value);
-      if (!isNaN(floatValue)) {
+      if (!Number.isNaN(floatValue)) {
         isMin ? setMinText(value) : setMaxText(value);
       }
     }

diff --git a/fiftyone/operators/types.py b/fiftyone/operators/types.py
@@ -1472,11 +1472,24 @@ def __init__(self, **kwargs):
 class LoadingView(ReadOnlyView):
     """Displays a loading indicator.
 
+    Examples::
+
+        schema_dots = {
+            text: "Loading dots only"
+        }
+        schema_spinner = {
+            variant: "spinner",
+            color: "primary",
+            size: "medium",
+        }
+        loading_dots = types.LoadingView(**schema_dots)
+        loading_spinner = types.LoadingView(**schema_spinner)
+
     Args:
-        text ("Loading"): a label for the loading indicator
-        variant ("spinner"): the variant of the loading indicator
-        color ("primary"): the color of the loading indicator
-        size ("medium"): the size of the loading indicator
+        text (None): a label for the loading indicator
+        variant (None): the variant of the loading indicator
+        color (None): the color of the loading indicator
+        size (None): the size of the loading indicator
     """
 
     def __init__(self, **kwargs):
@@ -1486,11 +1499,36 @@ def __init__(self, **kwargs):
 class PillBadgeView(ReadOnlyView):
     """Displays a pill shaped badge.
 
+    Examples::
+
+        schema_options_single_color = {
+            text: ["Reviewed", "Not Reviewed"],
+            color: "primary",
+            variant: "outlined",
+            show_icon: True
+        }
+
+         schema_options_multi_color = {
+            text: [["Not Started", "primary"], ["Reviewed", "success"], ["In Review", "warning"]],
+            color: "primary",
+            variant: "outlined",
+            show_icon: True
+        }
+
+         schema_single_option= {
+            text: "Reviewed",
+            color: "primary",
+            variant: "outlined",
+            show_icon: True
+        }
+        badge = types.PillBadgeView(**schema_options_single_color)
+
+
     Args:
-        text ("Reviewed" | ["Reviewed", "Not Reviewed"] | [["Not Started", "primary"], ["Reviewed", "success"], ["In Review", "warning"]): a label or set of label options with or without a color for the pill badge
-        color ("primary"): the color of the pill
-        variant ("outlined"): the variant of the pill
-        show_icon (False | True): whether to display indicator icon
+        text: a label or set of label options with or without a color for the pill badge
+        color (None): the color of the pill
+        variant (None): the variant of the pill
+        show_icon (None): whether to display indicator icon
     """
 
     def __init__(self, **kwargs):