-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imavid improvements + e2e #3893
Conversation
98a33d8
to
cffaacf
Compare
f2a399f
to
8b0d059
Compare
if (isImaVidLookerActive) { | ||
// assuming we're working with only one sample | ||
( | ||
lookerRef?.current as unknown as ImaVidLooker | ||
)?.frameStoreController.store?.updateSample( | ||
samples[0]._id, | ||
samples[0] | ||
); | ||
|
||
lookerRef?.current?.updateSample(samples[0]); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can an instance check be used? ImaVidLooker
can be added to the fos.Lookers
union type
if (isImaVidLookerActive) { | |
// assuming we're working with only one sample | |
( | |
lookerRef?.current as unknown as ImaVidLooker | |
)?.frameStoreController.store?.updateSample( | |
samples[0]._id, | |
samples[0] | |
); | |
lookerRef?.current?.updateSample(samples[0]); | |
} | |
const looker = lookerRef?.current; | |
if (looker instanceof ImaVidLooker) { | |
looker.frameStoreController.store?.updateSample( | |
samples[0]._id, | |
samples[0] | |
); | |
looker.updateSample(samples[0]); | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a looker.updateSamples
method could be added? Only one sample can be updated currently, but this would future proof selection/tagging changes and avoid accessing internal Looker data structures
if (necessaryFrameRange[1] < necessaryFrameRange[0]) { | ||
return; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be possible? It looks like getLookAheadFrameRange
should always return a valid range.
cffaacf
to
05cdb31
Compare
* more range check validation * fix tagging * remove log * fix imavid regression * upgrade dep versions * add watermarking option in image generator * fix frame one-off frame sync bug * move dynamic groups spec to groups folder * move dynamic groups spec to groups folder * add more data-cy attributes * differentiate grid and modal taggers * add speed controller * add toggleRenderFramesAsVideo * rename vars * add imavid tests * add screenshots * add data-cy to pathvalueentry * add tagging tests * remove unused vars * add modal tagger pom * add label count and sample count getters in siderbar * reset popups before play/pause
This PR: