bugfix: similarity search only works on default_group_slice

[lanzhenw]

What changes are proposed in this pull request?

Pass in the active session group slice as a parameter for similarity sort requests to update samples
Fixes a bug: similarity search only works on default_group_slice

similarity.mov

How is this patch tested? If it is not, please explain why.

import fiftyone as fo
import fiftyone.zoo as foz
import fiftyone.brain as fob

ds = foz.load_zoo_dataset('quickstart-groups',max_samples=50)
print(ds.default_group_slice) # prints 'left'
view = ds.select_group_slices('right')
fob.compute_similarity(view,model='clip-vit-base32-torch',brain_key='sim_right')

# now Open Dataset in FOT App. Select 'right' group slice. 
# Select an image in the grid or type in "mountian/road/anything" in similarity search prompt to run an Image Sim Search. 

# this should be working as expected

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

• No. You can skip the rest of this section.
• Yes. Give a description of this change to be included in the release
  notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

• App: FiftyOne application changes
• Build: Build and test infrastructure changes
• Core: Core fiftyone Python library changes
• Documentation: FiftyOne documentation changes
• Other

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release/v0.23.2@6870d39). Click here to learn what that means.

Additional details and impacted files

@@                Coverage Diff                 @@
##             release/v0.23.2    #3912   +/-   ##
==================================================
  Coverage                   ?   15.86%           
==================================================
  Files                      ?      731           
  Lines                      ?    81757           
  Branches                   ?     1093           
==================================================
  Hits                       ?    12974           
  Misses                     ?    68783           
  Partials                   ?        0           

Flag	Coverage Δ
app	15.86% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[benjaminpkane]

LGTM 🚀

[manivoxel51]

@lanzhenw this is great work! 🥇

I see three issues here and I think you have fixed the main one but two pending.

1. when a current active slice doesn't have a similarity computed, we still show the "Type anything" input. This causes confusion as the user can type "car" for example and the loading spinner will spin forever and a network error occurs without being surfaced to the client. The reason is that current slice is "left" for example but only "right" slice has similarity computed.

I think I know a fix, will push something for it.

2. If you compute similarity for "right slice". then search for "car". then switch back to left slice, app crashes.

@lanzhenw Can you look into this when you get a chance. end of video shows the crash

Video is app after your fix and my fix (1) above

Screen.Recording.2023-12-12.at.4.56.31.PM.mov

[manivoxel51]

@benjaminpkane @lanzhenw added this filters out a method if the activeSlice is not the one one with the similarity computed.

Shows help message for the active slice without similarity computed

Screen.Recording.2023-12-12.at.4.56.31.PM.mov

[manivoxel51]

Thank you! 🍨