Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate builtin operators when there's nothing to do #3914

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

brimoor
Copy link
Contributor

@brimoor brimoor commented Dec 11, 2023

Small tweak to the builtin delete_selected_samples and clone_selected_samples operators such that the Execute button will be disabled when there are no selected samples to delete/clone.

@brimoor brimoor added the enhancement Code enhancement label Dec 11, 2023
@brimoor brimoor requested a review from a team December 11, 2023 20:39
@brimoor brimoor self-assigned this Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4716506) 15.87% compared to head (52d4d2d) 15.87%.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/v0.23.2    #3914   +/-   ##
================================================
  Coverage            15.87%   15.87%           
================================================
  Files                  731      731           
  Lines                81557    81557           
  Branches              1093     1093           
================================================
  Hits                 12944    12944           
  Misses               68613    68613           
Flag Coverage Δ
app 15.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brimoor brimoor merged commit 7718cf5 into release/v0.23.2 Dec 15, 2023
9 checks passed
@brimoor brimoor deleted the builtin-operators-invalid branch December 15, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Code enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant