Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set dataset_id in params from op doc #3934

Merged
merged 3 commits into from
Dec 16, 2023

Conversation

kaixi-wang
Copy link
Contributor

@kaixi-wang kaixi-wang commented Dec 15, 2023

What changes are proposed in this pull request?

Set dataset_id and dataset_name using the delegate op doc so executing queued operations via command handlers work (since context.dataset isn't serialized in the doc the handler uses to queue the op)

@kaixi-wang kaixi-wang self-assigned this Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 96 lines in your changes are missing coverage. Please review.

Comparison is base (9c834a0) 15.87% compared to head (6cbf3c4) 15.85%.
Report is 14 commits behind head on release/v0.23.2.

Files Patch % Lines
...pp/packages/core/src/components/Actions/Tagger.tsx 0.00% 35 Missing ⚠️
app/packages/embeddings/src/tracesToData.tsx 0.00% 23 Missing ⚠️
app/packages/looker/src/elements/imavid/index.ts 0.00% 17 Missing ⚠️
...looker/src/lookers/imavid/ima-vid-frame-samples.ts 0.00% 7 Missing ⚠️
app/packages/looker/src/elements/video.ts 0.00% 4 Missing ⚠️
...packages/looker/src/elements/imavid/play-button.ts 0.00% 3 Missing ⚠️
app/packages/plugins/src/index.ts 0.00% 3 Missing ⚠️
.../src/components/Sidebar/Entries/PathValueEntry.tsx 0.00% 1 Missing ⚠️
.../packages/looker/src/elements/imavid/loader-bar.ts 0.00% 1 Missing ⚠️
...ckages/looker/src/elements/imavid/playback-rate.ts 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/v0.23.2    #3934      +/-   ##
===================================================
- Coverage            15.87%   15.85%   -0.02%     
===================================================
  Files                  731      731              
  Lines                81557    81629      +72     
  Branches              1093     1093              
===================================================
+ Hits                 12944    12946       +2     
- Misses               68613    68683      +70     
Flag Coverage Δ
app 15.85% <3.03%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nebulae
nebulae previously approved these changes Dec 15, 2023
@kaixi-wang kaixi-wang merged commit 0400384 into release/v0.23.2 Dec 16, 2023
9 checks passed
@kaixi-wang kaixi-wang deleted the kacey/make-queue-operation-teams-compat branch December 16, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants