-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for frames-as-videos in nested groups #3935
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/v0.23.2 #3935 +/- ##
=================================================
Coverage 15.85% 15.86%
=================================================
Files 731 731
Lines 81636 81853 +217
Branches 1093 1093
=================================================
+ Hits 12946 12987 +41
- Misses 68690 68866 +176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…de in dynamicgroup
df8dc36
to
d604156
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀 I think one edge case worth noting pcd slices have an unexpected behavior right now
Screen.Recording.2023-12-19.at.6.06.33.PM.mov
); | ||
|
||
useEffect(() => { | ||
// if it is unordered nested dynamic group and mode is not pagination, set to pagination |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re: pcd slices, will fix it in next PR!
Thanks for taking a look, and making it better! 🥳
This PR adds support for nested groups in imavid looker.
To recreate the dataset in the following gif: