Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fiftyone-db support for Ubuntu 23 #3936

Merged
merged 1 commit into from
Dec 20, 2023
Merged

Add fiftyone-db support for Ubuntu 23 #3936

merged 1 commit into from
Dec 20, 2023

Conversation

benjaminpkane
Copy link
Contributor

@benjaminpkane benjaminpkane commented Dec 18, 2023

Adds aarch64 an x86_64 downloads for Ubuntu 23 in the fiftyone-db. Resolves #3928

Support for Ubuntu 23 using Ubuntu 22 downloads can be verified in a docker container

docker run -it ubuntu:23.10 /bin/bash

In the container

apt update
apt install libcurl4 wget
wget https://fastdl.mongodb.org/linux/mongodb-linux-x86_64-ubuntu2204-7.0.4.tgz
tar -xvf mongodb-linux-x86_64-ubuntu2204-7.0.4.tgz
cd mongodb-linux-x86_64-ubuntu2204-7.0.4/bin/
./mongod --version

@benjaminpkane benjaminpkane self-assigned this Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 73 lines in your changes are missing coverage. Please review.

Comparison is base (9c834a0) 15.87% compared to head (12d4bc4) 15.85%.
Report is 15 commits behind head on release/v0.23.2.

Files Patch % Lines
...pp/packages/core/src/components/Actions/Tagger.tsx 0.00% 35 Missing ⚠️
app/packages/looker/src/elements/imavid/index.ts 0.00% 17 Missing ⚠️
...looker/src/lookers/imavid/ima-vid-frame-samples.ts 0.00% 7 Missing ⚠️
app/packages/looker/src/elements/video.ts 0.00% 4 Missing ⚠️
...packages/looker/src/elements/imavid/play-button.ts 0.00% 3 Missing ⚠️
app/packages/plugins/src/index.ts 0.00% 3 Missing ⚠️
.../src/components/Sidebar/Entries/PathValueEntry.tsx 0.00% 1 Missing ⚠️
.../packages/looker/src/elements/imavid/loader-bar.ts 0.00% 1 Missing ⚠️
...ckages/looker/src/elements/imavid/playback-rate.ts 0.00% 1 Missing ⚠️
...pp/packages/looker/src/elements/imavid/seek-bar.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/v0.23.2    #3936      +/-   ##
===================================================
- Coverage            15.87%   15.85%   -0.02%     
===================================================
  Files                  731      731              
  Lines                81557    81629      +72     
  Branches              1093     1093              
===================================================
+ Hits                 12944    12946       +2     
- Misses               68613    68683      +70     
Flag Coverage Δ
app 15.85% <3.94%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@swheaton swheaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't get it to work on my machine in docker (might be Mac M1 issues). However it can't hurt. So if it works for you, let's do it.

@swheaton swheaton merged commit 502a9ca into release/v0.23.2 Dec 20, 2023
23 checks passed
@swheaton swheaton deleted the ubuntu23 branch December 20, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants