Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a toggle to show/hide fields in sample modal that have undefined… #3937

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

manivoxel51
Copy link
Contributor

What changes are proposed in this pull request?

This was merged into develop by mistake.

How is this patch tested? If it is not, please explain why.

(Details)

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 154 lines in your changes are missing coverage. Please review.

Comparison is base (9c834a0) 15.87% compared to head (6a4d043) 15.86%.
Report is 15 commits behind head on release/v0.23.2.

Files Patch % Lines
...pp/packages/core/src/components/Actions/Tagger.tsx 0.00% 35 Missing ⚠️
...p/packages/core/src/components/Actions/Options.tsx 0.00% 31 Missing ⚠️
app/packages/embeddings/src/tracesToData.tsx 0.00% 23 Missing ⚠️
app/packages/looker/src/elements/imavid/index.ts 0.00% 17 Missing ⚠️
.../src/components/Sidebar/Entries/PathValueEntry.tsx 0.00% 16 Missing ⚠️
app/packages/core/src/components/Modal/Modal.tsx 0.00% 12 Missing ⚠️
...looker/src/lookers/imavid/ima-vid-frame-samples.ts 0.00% 7 Missing ⚠️
app/packages/looker/src/elements/video.ts 0.00% 4 Missing ⚠️
...packages/looker/src/elements/imavid/play-button.ts 0.00% 3 Missing ⚠️
app/packages/plugins/src/index.ts 0.00% 3 Missing ⚠️
... and 3 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/v0.23.2    #3937      +/-   ##
===================================================
- Coverage            15.87%   15.86%   -0.01%     
===================================================
  Files                  731      731              
  Lines                81557    81697     +140     
  Branches              1093     1093              
===================================================
+ Hits                 12944    12961      +17     
- Misses               68613    68736     +123     
Flag Coverage Δ
app 15.86% <10.46%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manivoxel51 manivoxel51 merged commit 028d866 into release/v0.23.2 Dec 18, 2023
12 of 13 checks passed
@manivoxel51 manivoxel51 deleted the sunny/hide-none-fields branch December 18, 2023 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants